$j = 0;
for($i=0; $i<$count; $i++)
{
	while(true)
	{
		try
		{
			$code = str_makerand();
			$codeID = $this->addItem(
				$this->tableNameCodes,
				array('code'),
				array($code)
			);

			break;
		}
		catch(Exception $e){
			$j++;
			if($j=10) break;
		}
	}
}

Bookmark It

NOTE: Have in mind that the CI and PHPLIST have a common function named “redirect”. You either need to rename that in CI or in PHPLIST.

<?php if (!defined('BASEPATH')) exit('No direct script access allowed');

/**
* CodeIgniter phplist Library
*
* CodeIgniter phplist bridge allowing adding users to lists and blacklisting them
*
* @author Georgi Budinov
* @version	1.0
* @link http://georgi.budinov.com
*/
class Phplist_library
{
    public $CI;

    /**
     * Constructor.
     */
    public function __construct()
    {
    	global $tables, $table_prefix, $config, $usertable_prefix, $database_connection;
        if (!isset($this->CI))
		{
			$this->CI =& get_instance();
		}

		$rootPath = $this->CI->config->item('root_path');

		define('BULLETIN_ROOT_PATH', $rootPath.'bulletin/');

		$phplist_root_path = (defined('PHPLIST_ROOT_PATH')) ? PHPLIST_ROOT_PATH : BULLETIN_ROOT_PATH;

		// Include needed files
		include($phplist_root_path . 'admin/defaultconfig.inc');
		include($phplist_root_path . 'config/config.php');
		include($phplist_root_path . 'admin/mysql.inc');
		include($phplist_root_path . 'admin/connect.php');
    }

    /**
     *
     * @param $email
     * @param $lists
     * @return mixed
     */
    public function user_add($email, $lists = array())
    {
    	if(!$email) return false;

    	if(is_array($lists) && count($lists))
    	{
    		$userID = addNewUser($email);

    		if($userID > 0)
    		{
    			foreach($lists as $list)
    			{
    				$this->userAddToList($userID, $list);
    			}
    		}
    	}
    	else
    	{
        	return addNewUser($email);
    	}
    }

	public function get_lists()
    {
    	$results = $this->getLists();

    	return $results;
    }

	public function user_add_list($email, $list)
    {
    	if(!$email || !$list) return;

    	$userid = $this->getUserIDByEmail($email);

    	if($userid > 0)
    	{
    		$this->userAddToList($userid, $list);
    	}
    	else
    	{
    		return;
    	}
    }

	public function user_remove_list($email, $list)
    {
    	if(!$email || !$list) return;

    	$userid = $this->getUserIDByEmail($email);

    	if($userid > 0)
    	{
    		$this->userRemoveToList($userid, $list);
    	}
    	else
    	{
    		return;
    	}
    }

    /**
     *
     * @param $email
     * @return mixed
     */
    public function user_blacklist($email)
    {
    	if(!$email) return;

    	return addUserToBlackList($email);
    }

	/**
     *
     * @param $email
     * @return mixed
     */
    public function user_unblacklist($email)
    {
    	if(!$email) return;

    	$userid = $this->getUserIDByEmail($email);

    	if($userid > 0)
    	{
    		return unBlackList($userid);
    	}
    	else
    	{
    		return false;
    	}
    }

	private function getUserIDByEmail($email = '') {
	  global $tables, $table_prefix, $config, $usertable_prefix, $database_connection;
	  if (!$email) return;

	  # workaround for integration webbler/phplist
	  if (!isset($table_prefix))
	    $table_prefix = "phplist_";

	  if (isset($tables["attribute"])) {
	    $att_table = $tables["attribute"];
	    $user_att_table = $tables["user_attribute"];
	    $usertable = $tables["user"];
	  } else {
	    $att_table = "attribute";
	    $user_att_table = "user_attribute";
	    $usertable = "user";
	  }
	  $email = mysql_real_escape_string($email, $database_connection);
	  $userid = Sql_Fetch_Row_Query("select id from {$usertable} where email = \"$email\"");
	  $id = $userid[0];

	  return $id;
	}

	private function userAddToList($id = 0, $listID = 0)
	{
		global $tables, $table_prefix, $config, $usertable_prefix, $database_connection;

		$id = intval($id);
		$listID = intval($listID);
		if(!$id || !$listID) return false;

		$query = "replace into ".$tables["listuser"]." (userid,listid,entered) values($id,$listID,now())";
	    $result = Sql_query($query);
	}

	private function userRemoveToList($id = 0, $listID = 0)
	{
		global $tables, $table_prefix, $config, $usertable_prefix, $database_connection;

		$id = intval($id);
		$listID = intval($listID);
		if(!$id || !$listID) return false;

		$query = "delete from ".$tables["listuser"]." where userid = $id and listid = $listID";
	    $result = Sql_query($query);
	}

	private function getLists()
	{
		global $tables, $table_prefix, $config, $usertable_prefix, $database_connection;

		$results = array();
		$result = Sql_query("SELECT * FROM {$tables['list']} order by listorder");
		while ($row = Sql_fetch_array($result))
		{
			$results[$row['id']] = $row;
		}

		return $results;
	}
}

/* End of file phplist_library.php */
/* Location: ./application/libraries/phplist_library.php */

Bookmark It

• performance
• easy management – adding new fields, deleting existing fields and so on

As I see it, there are three approaches that deserve our attention:

• the most common, mostly used in the past (according to me) – single table holding all the fields: common fields + language fields
• the multilanguage tables – each language has own table that complement the data in the common table
• single multilanguage table complementing the common table – the multilingual table has a primary key on id from the common table and the language

So I decided to investigate what is the best solution to use. Here is the database structure I used:

• the first way:

CREATE TABLE IF NOT EXISTS `simplest` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`title_en` varchar(255) NOT NULL DEFAULT ‘ ‘,
`title_bg` varchar(255) NOT NULL DEFAULT ‘ ‘,
`body_en` text NOT NULL,
`body_bg` text NOT NULL,
`sum_en` int(11) NOT NULL DEFAULT ’0′,
`sum_bg` int(11) NOT NULL DEFAULT ’0′,
PRIMARY KEY (`id`)
) ENGINE=MyISAM  DEFAULT CHARSET=utf8

• the second way

CREATE TABLE IF NOT EXISTS `lang_tbls` (
`id` int(20) NOT NULL AUTO_INCREMENT,
PRIMARY KEY (`id`)
) ENGINE=MyISAM

CREATE TABLE IF NOT EXISTS `lang_tbls_bg` (
`id` int(11) NOT NULL DEFAULT ’0′,
`title` varchar(255) NOT NULL DEFAULT ‘ ‘,
`body` text NOT NULL,
`sum` int(11) NOT NULL DEFAULT ’0′,
KEY `id` (`id`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

CREATE TABLE IF NOT EXISTS `lang_tbls_en` (
`id` int(11) NOT NULL DEFAULT ’0′,
`title` varchar(255) NOT NULL DEFAULT ‘ ‘,
`body` text NOT NULL,
`sum` int(11) NOT NULL DEFAULT ’0′,
KEY `id` (`id`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

• and the third option

CREATE TABLE IF NOT EXISTS `one_tbl` (
`id` int(20) NOT NULL AUTO_INCREMENT,
PRIMARY KEY (`id`)
) ENGINE=MyISAM

CREATE TABLE IF NOT EXISTS `one_tbl_lang` (
`id` int(11) NOT NULL DEFAULT ’0′,
`lang` char(2) NOT NULL DEFAULT ‘en’,
`title` varchar(255) NOT NULL DEFAULT ‘ ‘,
`body` text NOT NULL,
`sum` int(11) NOT NULL DEFAULT ’0′,
PRIMARY KEY (`id`,`lang`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8;

Now as we know what are the options in details let us first see what is the best structure to be easy to maintain and extend. As you can suppose this is the last one. When needed to add a new lang … nothing to be done in the database. When needed to add a new field …. just alter one table. Between the first two choices better is the second just because the languages are separated and it is easier to manage, but having more tables of course.

Ok now the real deal – performace. I have created the structure above on my localhost mysql database. Then made a script and imported data of 5000 rows and then 10000 rows. Ran a few queries that according to me are mostly used and important to make the difference. And these are the results:

0.0018 sec/5000 rec, 0.0018 sec/10000 rec,
SELECT * FROM `simplest` WHERE 1 LIMIT 20 OFFSET 1000
0.0064 sec/5000 rec, 0.0152 sec/10000 rec,
SELECT * FROM `simplest` WHERE title_en LIKE ‘%ass%’ LIMIT 20
0.0090 sec/5000 rec, 0.0190 sec/10000 rec,
SELECT * FROM `simplest` WHERE title_en LIKE ‘%ass%’ OR title_bg LIKE ‘%ass%’ LIMIT 20

0.0030 sec/5000 rec, 0.0037 sec/10000 rec
SELECT * FROM `lang_tbls` t INNER JOIN `lang_tbls_en` l ON (t.id = l.id) WHERE 1 LIMIT 20 OFFSET 1000
0.0057 sec/5000 rec, 0.0060 sec/10000 rec
SELECT * FROM `lang_tbls` t INNER JOIN `lang_tbls_en` l ON (t.id = l.id) WHERE l.title LIKE ‘%ass%’ LIMIT 10
0.0116 sec/5000 rec, 0.0120 sec/10000 rec
SELECT * FROM `lang_tbls` t INNER JOIN `lang_tbls_en` l1 ON (t.id = l1.id) INNER JOIN `lang_tbls_bg` l2 ON (t.id = l2.id) WHERE 1 LIMIT 20 OFFSET 1000
0.0292 sec/5000 rec, 0.0325 sec/10000 rec
SELECT * FROM `lang_tbls` t INNER JOIN `lang_tbls_en` l1 ON (t.id = l1.id) INNER JOIN `lang_tbls_bg` l2 ON (t.id = l2.id) WHERE l1.title LIKE ‘%ass%’ OR l2.title LIKE ‘%ass%’ LIMIT 10
0.0157 sec/5000 rec, 0.0175 sec/10000 rec
SELECT * FROM `lang_tbls` t LEFT JOIN `lang_tbls_en` l1 ON (t.id = l1.id) LEFT JOIN `lang_tbls_bg` l2 ON (t.id = l2.id) WHERE 1 LIMIT 20 OFFSET 1000
0.0405 sec/5000 rec, 0.0445 sec/10000 rec
SELECT * FROM `lang_tbls` t LEFT JOIN `lang_tbls_en` l1 ON (t.id = l1.id) LEFT JOIN `lang_tbls_bg` l2 ON (t.id = l2.id) WHERE l1.title LIKE ‘%ass%’ OR l2.title LIKE ‘%ass%’ LIMIT 10

0.0098 sec/5000 rec, 0.0099 sec/10000 rec
SELECT * FROM `one_tbl` t INNER JOIN `one_tbl_lang` l ON (t.id = l.id AND l.lang = ‘en’) WHERE 1 LIMIT 20 OFFSET 1000
0.0430 sec/5000 rec, 0.0470 sec/10000 rec
SELECT * FROM `one_tbl` t INNER JOIN `one_tbl_lang` l ON (t.id = l.id AND l.lang = ‘en’) WHERE l.title LIKE ‘%ass%’ LIMIT 10
0.0025 sec/5000 rec, 0.0030 sec/10000 rec
SELECT * FROM `one_tbl` t INNER JOIN `one_tbl_lang` l ON (t.id = l.id AND (l.lang = ‘en’ OR l.lang = ‘bg’)) WHERE 1 LIMIT 20 OFFSET 1000
0.0060 sec/5000 rec, 0.0067 sec/5000 rec
SELECT * FROM `one_tbl` t INNER JOIN `one_tbl_lang` l ON (t.id = l.id AND (l.lang = ‘en’ OR l.lang = ‘bg’)) WHERE l.title LIKE ‘%ass%’ LIMIT 10
0.0170 sec/5000 rec, 0.0184 sec/5000 rec
SELECT * FROM `one_tbl` t LEFT JOIN `one_tbl_lang` l1 ON (t.id = l1.id AND l1.lang = ‘en’) LEFT JOIN `one_tbl_lang` l2 ON (t.id = l2.id AND l2.lang = ‘bg’) WHERE 1 LIMIT 20 OFFSET 1000
0.0457 sec/5000 rec, 0.0485 sec/10000 rec
SELECT * FROM `one_tbl` t LEFT JOIN `one_tbl_lang` l1 ON (t.id = l1.id AND l1.lang = ‘en’) LEFT JOIN `one_tbl_lang` l2 ON (t.id = l2.id AND l2.lang = ‘bg’) WHERE l1.title LIKE ‘%ass%’ OR l2.title LIKE ‘%ass%’ LIMIT 10

I think that it is really clear the the first choice is best in terms of performance. The queries I have used for the latter options are more because there is difference in what exactly you want to get from the database using different types of joins, which one can do with no joins in the first option. So if you want to emphasis on performance that is for you!

Ok let’s move on – the second and the third. As you can see the third option is better just in queries 3 and 4 – quite better I would say. But according to me these queries are queries that are rarely used. The can be used for searches in the databases for both languages which is really rare wanted feature, really. In all other queries the second option is better. So if you want to emphasis on maintenance and easy development – option 3 is for you.

But if you want to be between the two requirements – use the second option.

Bookmark It